ubuntuusers.de

Walter-O schrieb:

Soll Ich die Ausgabe von shellcheck hier mal Einfügen?

Ja, in code-block.

@lubux

iob@iob:~$ shellcheck --shell=bash --enable=all ./install_hannah.sh

In ./install_hannah.sh line 37:
[[ $EUID -eq 0 ]] || err "This script must be run as root (try: sudo bash)."
   ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
[[ ${EUID} -eq 0 ]] || err "This script must be run as root (try: sudo bash)."


In ./install_hannah.sh line 54:
[[ -n "$UPDATE_SERVER_TOKEN" ]] && AUTH_HEADER=(-H "Authorization: Bearer ${UPDATE_SERVER_TOKEN}")
       ^------------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
[[ -n "${UPDATE_SERVER_TOKEN}" ]] && AUTH_HEADER=(-H "Authorization: Bearer ${UPDATE_SERVER_TOKEN}")


In ./install_hannah.sh line 60:
LATEST_VERSION=$(echo "$LATEST_JSON" | python3 -c "import sys,json; print(json.load(sys.stdin)['version'])")
                       ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
LATEST_VERSION=$(echo "${LATEST_JSON}" | python3 -c "import sys,json; print(json.load(sys.stdin)['version'])")


In ./install_hannah.sh line 68:
    -o "$TMPFILE" \
        ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
    -o "${TMPFILE}" \


In ./install_hannah.sh line 74:
tar -xzf "$TMPFILE" -C "${INSTALL_DIR}"
          ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
tar -xzf "${TMPFILE}" -C "${INSTALL_DIR}"


In ./install_hannah.sh line 79:
if [[ ! -d "$VENV" ]]; then
            ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
if [[ ! -d "${VENV}" ]]; then


In ./install_hannah.sh line 81:
    python3 -m venv "$VENV"
                     ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
    python3 -m venv "${VENV}"


In ./install_hannah.sh line 90:
if ! id "$SERVICE_USER" &>/dev/null; then
         ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
if ! id "${SERVICE_USER}" &>/dev/null; then


In ./install_hannah.sh line 92:
    useradd -r -s /sbin/nologin "$SERVICE_USER"
                                 ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
    useradd -r -s /sbin/nologin "${SERVICE_USER}"


In ./install_hannah.sh line 97:
if [[ ! -d "$CONFIG_DIR" ]]; then
            ^---------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
if [[ ! -d "${CONFIG_DIR}" ]]; then


In ./install_hannah.sh line 98:
    mkdir -p "$CONFIG_DIR"
              ^---------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
    mkdir -p "${CONFIG_DIR}"


In ./install_hannah.sh line 99:
    chown "${SERVICE_USER}:${SERVICE_USER}" "$CONFIG_DIR"
                                             ^---------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
    chown "${SERVICE_USER}:${SERVICE_USER}" "${CONFIG_DIR}"


In ./install_hannah.sh line 104:
install -m 644 "${INSTALL_DIR}/deploy/hannah.service" "$SERVICE_FILE"
                                                       ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.

Did you mean:
install -m 644 "${INSTALL_DIR}/deploy/hannah.service" "${SERVICE_FILE}"

For more information:
  https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
iob@iob:~$

Die Ausgabe von shellcheck ist OK, denn sie zeigt/beinhaltet keine Fehlerhinweise. Es geht nur um den Stil wie das bash-Script verfasst worden ist.

Versuch mal eine kleine Änderung im Script, bei curl, um evtl. Hinweise zu bekommen warum der Download nicht funktioniert. Ersetze dort das "-sf" durch "-fSL" und führe das Script erneut so aus:

sudo bash -x ./install_hannah.sh

@lubux

iob@iob:~$ curl -fSL https://raw.githubusercontent.com/NurPech/hannah/master/core/deploy/install.sh | sudo bash
  % Total    % Received % Xferd  Average Speed  Time    Time    Time   Current
                                 Dload  Upload  Total   Spent   Left   Speed
100   5847 100   5847   0      0 105.4k      0                              0[sudo: authenticate] Password: 
        
[INFO]  Fetching latest core release from https://hannah-update.sgessinger.de (channel: core-stable) ...
[INFO]  Latest version: v0.75.8
iob@iob:~$ sudo bash -x ./install_hannah.sh
+ set -euo pipefail
+ UPDATE_SERVER_URL=https://hannah-update.sgessinger.de
+ UPDATE_SERVER_TOKEN=
+ CORE_CHANNEL=core-stable
+ INSTALL_DIR=/opt/hannah/core
+ CONFIG_DIR=/etc/hannah
+ SERVICE_NAME=hannah
+ SERVICE_FILE=/etc/systemd/system/hannah.service
+ SERVICE_USER=hannah
+ need python3
+ command -v python3
+ need curl
+ command -v curl
+ need systemctl
+ command -v systemctl
+ [[ 0 -eq 0 ]]
+ [[ '' == \-\-uninstall ]]
+ AUTH_HEADER=()
+ [[ -n '' ]]
+ info 'Fetching latest core release from https://hannah-update.sgessinger.de (channel: core-stable) ...'
+ echo '[INFO]  Fetching latest core release from https://hannah-update.sgessinger.de (channel: core-stable) ...'
[INFO]  Fetching latest core release from https://hannah-update.sgessinger.de (channel: core-stable) ...
++ curl -sf 'https://hannah-update.sgessinger.de/latest?channel=core-stable'
+ LATEST_JSON='{"version":"v0.75.8","revision":1,"url":"http://hannah-update.sgessinger.de/releases/v0.75.8?channel=core-stable","sha256":"c194b8651701d458afbb5804eb3aed76de16cec23bca9daea73b3b163fe2191d","size":154398}'
++ echo '{"version":"v0.75.8","revision":1,"url":"http://hannah-update.sgessinger.de/releases/v0.75.8?channel=core-stable","sha256":"c194b8651701d458afbb5804eb3aed76de16cec23bca9daea73b3b163fe2191d","size":154398}'
++ python3 -c 'import sys,json; print(json.load(sys.stdin)['\''version'\''])'
+ LATEST_VERSION=v0.75.8
+ info 'Latest version: v0.75.8'
+ echo '[INFO]  Latest version: v0.75.8'
[INFO]  Latest version: v0.75.8
++ mktemp /tmp/hannah-core-XXXXXX.tar.gz
+ TMPFILE=/tmp/hannah-core-4lfR6P.tar.gz
+ trap 'rm -f "$TMPFILE"' EXIT
+ curl -sf -o /tmp/hannah-core-4lfR6P.tar.gz 'https://hannah-update.sgessinger.de/releases/v0.75.8?channel=core-stable'
+ rm -f /tmp/hannah-core-4lfR6P.tar.gz
iob@iob:~$

In dieser Zeile/Ausgabe:

+ LATEST_JSON='{"version":"v0.75.8","revision":1,"url":"http://hannah-update.sgessinger.de/releases/v0.75.8?channel=core-stable","sha256":

fehlt das https. Ändere im Script das https (bei curl) in http und teste erneut. Oder Du machst erstmal nichts und zeigst dem Server-Betreiber diese/deine vollständige Ausgabe (mit "bash -x").

@Walter-O

Bitte unterlasse Fullquotes. Sie blähen den Thread nur sinnlos auf.

Lies dazu Zitate & Verhaltenskodex/Fullquote.

Da steht eindeutig:

Hier wird ausdrücklich von "Teile eines vorherigen Beitrags" gesprochen, gesamte -also komplette- Beitragen zu zitieren ist unerwünscht.

Und wenn man direkt antwortet reicht ein @[user:Benutzername:] da braucht es garkein Zitat.

@schwarzheit Sorry, werde mich daran halten.

@lubux Meinen dank an dich, wende mich nochmal an den Betreiber.